Add missing argument to OSSHandler's _format_prompt function
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuanzhiMao
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Looks great! Thanks for contributing @eitanturok
btw, which code formatter are you using? The import sorting feature seems handy :)
|
It is a code formatter extension in VSCode: https://marketplace.visualstudio.com/items?itemName=ms-python.isort. |
HuanzhiMao
approved these changes
Apr 22, 2024
Fanjia-Yan
approved these changes
Apr 22, 2024
ShishirPatil
approved these changes
Apr 23, 2024
devanshamin
pushed a commit
to devanshamin/gorilla
that referenced
this pull request
Jul 9, 2024
…shirPatil#373) # Overview In this PR, I added a missing argument to `OSSHandler`'s `_format_prompt` function. Also my code formatter sorted the imports alphabetically which accounts for all the other changes, including those in `handler_map.py`. # What Happened? In every model handler, we define `_format_prompt` as taking in three arguments (`prompt`, `function`, `test_category`). This is the standard. But in `OSSHandler`, `_format_prompt` is defined as only taking in `prompt` and `function` and forgetting to take `test_category` as an input. This caused an error. So I simply added `test_category` to the definition of `_format_prompt`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In this PR, I added a missing argument to
OSSHandler's_format_promptfunction.Also my code formatter sorted the imports alphabetically which accounts for all the other changes, including those in
handler_map.py.What Happened?
In every model handler, we define
_format_promptas taking in three arguments (prompt,function,test_category). This is the standard. But inOSSHandler,_format_promptis defined as only taking inpromptandfunctionand forgetting to taketest_categoryas an input.This caused an error. So I simply added
test_categoryto the definition of_format_prompt.