Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests across project #2

Closed
Shivam010 opened this issue Aug 30, 2019 · 6 comments
Closed

Add unit tests across project #2

Shivam010 opened this issue Aug 30, 2019 · 6 comments
Assignees
@Shivam010
Labels
good first issue Good for newcomers up-for-grabs Label associated with the up-for-grabs.net

Comments

@Shivam010
Copy link
Owner

Need to add unit tests for the handler in main.go and the helper functions in helper.go, so is to avoid any future bug.
@Shivam010 Shivam010 added good first issue Good for newcomers up-for-grabs Label associated with the up-for-grabs.net labels Aug 30, 2019
@ahmedsharif865
Copy link

Is someone still working on this issue?

@Shivam010
Copy link
Owner Author

No, would you like to contribute?

Shivam010 added a commit that referenced this issue Sep 7, 2019
@Shivam010
feat: Makefile introduced, tests added #2
57b8477 
Also, corresponding action/workflow updated
@Shivam010 Shivam010 mentioned this issue Sep 7, 2019
Merged
8 tasks
Shivam010 added a commit that referenced this issue Sep 7, 2019
@Shivam010
fix: omitting the body check for http dial error #2
f626cae
@jmhobbs jmhobbs mentioned this issue Oct 2, 2019
Closed
@jmhobbs
Copy link

jmhobbs commented Oct 2, 2019

@Shivam010 Hello! I added some tests for helper methods in #9. Would you like a config file set up for a CI tool? I personally like Travis but have experience configuring CircleCI too.

@Shivam010
Copy link
Owner Author

Hi @jmhobbs, thank you for your contribution. It would be better for me if you would add your contribution in #6 and create a PR for dev branch. I have some tests written in it.

Follow the PR #6 and checkbox #6 (comment)

@Shivam010
Copy link
Owner Author

Also, regarding the CI config, it's already set in with GitHub Actions https://github.com/Shivam010/bypass-cors/actions

@jmhobbs jmhobbs mentioned this issue Oct 5, 2019
Closed
@Shivam010 Shivam010 self-assigned this Jun 23, 2020
@Shivam010 Shivam010 mentioned this issue Jun 23, 2020
Closed
@Shivam010
Copy link
Owner Author

Unit tests for pre-flight requests are only left to check.
Closing this issue and creating a new one for pre-flight request
Thank you

PS: New Issue #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shivam010 Shivam010

Labels
good first issue Good for newcomers up-for-grabs Label associated with the up-for-grabs.net
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmhobbs @Shivam010 @ahmedsharif865