add error sound

[ShizukuIchi]

No description provided.

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://winxp-git-feature-error-sound.shizukuichi.now.sh

[ShizukuIchi]

#62

[panmona]

This is the exact modification I imagined, it fixes the concerns from #62.
I'm pretty sure it won't work in Safari and other browsers (mobile chrome) that restrict playing of sounds to be a result of a user interaction. I think the code modifications needed for that would be a lot bigger though and as this is just an enhancement I think it's good enough. (but I don't know this code base really well)

TL,DR: This is great!

[VocalFan]

Well, don't users have to use the website in order to activate the error sound? So isn't the website interacted with?

[panmona]

@ghostslayer989 The restriction is that it must be called from an onClick Handler.

[panmona]

Small follow up to illustrate what I mean:
Unhandled Promise Rejection: NotAllowedError: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission. (Safari)
But as I said before this is fine.

[panmona]

How difficult would it be though to move the sound handling directly into the onClick handler?