-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
high pct tick #47
Comments
the interval for this task is currently 5 mins. will anything break if i change it to 50 mins? |
If you're confident that the server won't crash anytime then sure, but I already made optimizations and might push them soon |
im not confident can u make push that |
I'm waiting for recursive inventories get fixed in InvMenu, until then I could use a delayed task to send menus as a workaround but it might not work all the time so I'm not sure. |
I currently have a workaround that seems to work, if it doesn't break and everything else works fine I'll push it today |
- Optimizations (#47) - Added missing settings - Added price format option to add commas Optimizations: - Pagination no longer uses a new class all the time - Pagination system now uses array_slice() - DB is now updated when a listing is created or expired - Other small things
does it break |
Everything seems to be fine, I pushed a release an hour ago |
should i use that |
I made optimizations in other areas besides the task so yeah |
oh ok will it no longer be 200+% pct tick then |
The timings seemed to be good when I tested it, you can try it and check the results just to make sure |
why when i download 1.2 branch i get something else |
there is also no commando in virions:. |
Are you downloading from the releases tab? |
ok that fixed it thanks a lot good job keep it up |
the pct tick improved a lot what did u do? |
thanks, you can look at the description and changes here: ae18be6 I pretty much went over the plugin and checked everything I was able to optimize, even the small things |
|
if not, i think i want to do that for my plugin too to save stats when the player leaves instead of all player at once every other time. |
Not necessarily since I don't think listings would be created that often and the DB lib is async too, it would actually be better in case of a fatal server crash |
everything in libasynql is async right including update |
yes |
do you think it would be a bad idea to save stats ;like kills and deaths to SQLite every time the player leaves? |
The text was updated successfully, but these errors were encountered: