-
Notifications
You must be signed in to change notification settings - Fork 75
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/Stream/ byterange is broken #787
Comments
We should be using |
Also which endpoint is actually broken, since you just pointed to an entire Controller being "broken" |
Nancy code worked fine, you could seek video without issue. |
Maybe is a matter of missing headers, because of |
|
|
curl is not a player... |
And further to this chrome doesn't do byte ranges. |
Only thing I can see in wireshark is:
|
What I need to try and debug this... is a way of replicating it @bigretromike as I said I need a way of reproducing the issue |
Install Kodi, Install Nakamori, go to any series, play any file, profit with debugging; |
or better, I can push that change to repo, so you dont have to change anything in nakamori by hand. |
Is there a simpler for example other players and such that also do this? Since a setup with Kodi/Nakamori isn't the easiest |
VLC does it if you feed it the URL I believe |
its super simple!
edit: step 3 is not nessasary because if you skip it kodi will ask for it and navigate you there. |
If someone asks for an easier setup, it usually means that they want to replicate the issue at a core, not install a few things.... |
Sorry, @da3dsoul did wrote the original code and I never test it against with anything other than Kodi, so I cannot give you 100% sure info about anything else. |
I found the issue, it seems to be the missing response headers, working on a way of fixing it properly |
But yeah for future reference BRM, your initial report was saying the stream controller didn't support byte ranges. This would have been best to report as "Streaming files via HTTP does not allow seeking" |
I can confirm that this is finally working. Also for future reference if you rewrite something, It would be awesome if you check big part of it ;) and test if its compatible, or just delete legacy code away if its not tested :-) imo. But than again, thank you for fixing the error from rewrite process, I knew that if you can't do it no one would (except old @da3dsoul) - you are the NetCore expert here 👍 I take your words to my heart and will try to give you less specific titles of issues, or those that im 100% sure of. |
With the scale of changes at the time, testing was still to be done @bigretromike.... And if you want to check on that, check the netcore branch and the amount of commits that were done. |
I'm not complaining, I'm happy that the very important function is working :-) You did great job, I'm still looking forward 👍 |
/Stream/ byterange is broken because of Context is null.
Just a remainder
The text was updated successfully, but these errors were encountered: