Add base64 converter for chapter name in mediainfo #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was not able to use the specific type to just target the object with @dt and #value |
harshithmohan
commented
Aug 25, 2022
| break; | ||
| } | ||
| default: | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
Was not sure what to put for default case.
There was a problem hiding this comment.
Throw something more specific then a not implemented description, or at least provide a message
There was a problem hiding this comment.
If it's intentionally not implemented, I tend to go for a NotSupportedException
There was a problem hiding this comment.
I changed it to
throw new NotSupportedException("Unknown type encountered in MenuStream.extra");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure I wrote it properly.. but it worksTM