Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for parallel migrations #6

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Support for parallel migrations #6

merged 4 commits into from
Apr 24, 2020

Conversation

kedder
Copy link
Member

@kedder kedder commented Apr 23, 2020

Add command-line flag to specify concurrency level and test parallel migrations feature.

When provided, upgrade scripts are executed in parallel for databases,
provided by backend.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 91.512% when pulling a846dec on multiprocessing into 0c74a68 on master.

@coveralls
Copy link

coveralls commented Apr 23, 2020

Coverage Status

Coverage increased (+1.1%) to 92.06% when pulling 91c0726 on multiprocessing into 0c74a68 on master.

@kedder
Copy link
Member Author

kedder commented Apr 23, 2020

I'm not happy with the fact that this implementation opens all the connections before it starts processing migrations. Will deal with this tomorrow.

Consume connection generator only when workers are available.
Database connections are typically not serializable and we cannot pass
them to subprocesses. So, perform connection explicitly with new
Backend.begin() method only inside worker process.
@kedder kedder merged commit 75c4b18 into master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants