Merge pull request #90 from Shoobx/fix-metaclass-conflict

Fix metaclass conflict
Shoobx · Feb 10, 2023 · 9fc2bd7 · 9fc2bd7
2 parents 88308ac + a9954b7
commit 9fc2bd7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 75 deletions.
diff --git a/src/mypy_zope/plugin.py b/src/mypy_zope/plugin.py
@@ -719,13 +719,8 @@ def _apply_interface(self, impl: TypeInfo, iface: TypeInfo) -> None:
         # there is a decorator for the class that will create a "type promotion",
         # but ensure this only gets applied a single time per interface.
         promote = Instance(iface, [])
-        if not any(promote in ti._promote for ti in impl.mro):
-            faketi = TypeInfo(SymbolTable(), iface.defn, iface.module_name)
-            faketi._promote = [promote]
-            faketi.metaclass_type = iface.metaclass_type
-            # Insert the TypeInfo before the builtins.object that's at the end.
-            assert impl.mro[-1].fullname == 'builtins.object'
-            impl.mro.insert(len(impl.mro) - 1, faketi)
+        if promote not in impl._promote:
+            impl._promote.append(promote)
 
 
 def plugin(version: str) -> PyType[Plugin]:

diff --git a/tests/test_mro_calculation.py b/tests/test_mro_calculation.py