Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed use of FileType in argument specification #74

Merged
merged 1 commit into from Jan 28, 2021

Conversation

toyg
Copy link
Contributor

@toyg toyg commented Jan 28, 2021

This allows us to handle files directly in lxml, which solves #72 and likely increases performance and exactness all around.

@regebro
Copy link
Contributor

regebro commented Jan 28, 2021

Looks good. I haven't thought about encodings with regards to patch files at all, but at least this should then not open them in cp1252 by default on Windows.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 257

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 99.689%

Files with Coverage Reduction New Missed Lines %
xmldiff/main.py 1 98.8%
Totals Coverage Status
Change from base Build 255: -0.1%
Covered Lines: 962
Relevant Lines: 965

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jan 28, 2021

Pull Request Test Coverage Report for Build 257

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 99.689%

Files with Coverage Reduction New Missed Lines %
xmldiff/main.py 1 98.8%
Totals Coverage Status
Change from base Build 255: -0.1%
Covered Lines: 962
Relevant Lines: 965

💛 - Coveralls

@regebro
Copy link
Contributor

regebro commented Jan 28, 2021

One unchanges line lost coverage? That must be a glitch. I think we can ignore that.

@regebro regebro merged commit c6f2e88 into Shoobx:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants