メインページに終了後・開催中・予定されたコンテストおよびユーザーのランキングの表示をした #261
Merged
+415
−26,522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
新しく開始時間と終了時間を指定してコンテストの一覧を取得するAPIを作ることでこの３つのAPIは共通化できるのでしたほうがいいかもしれません。もしそうなら修正いたします |
ShopOne
reviewed
Dec 7, 2021
src/main/kotlin/com/nazonazo_app/shit_forces/contest/ContestService.kt
Outdated
Show resolved
Hide resolved
|
APIの修正はいったんいいかなと思います 共通化するよりは、3つの関数の上位関数(呼び方がわからない)を作る方針にしたいと思います。 |
|
LatestContestsInfoという型名は適切でないと感じたため、ContestInfoListに変更しました。 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
終了後・開催中・予定されたコンテストのAPIをそれぞれ作り、それをフロントの方で表示しました。
また、ユーザーのランキングも表示しました
マージ後のイメージ