Baleen <-> Avro generators #6
Conversation
In order to add validation to existing Avro schemas, use this utility to create Baleen descriptions from your legacy Avro schemas
Convert your Baleen data descriptions into Avro schemas to use in data serialization. This updates the Work-in-progress Avro schema generator
| value == null -> sequenceOf(ValidationError(dataTrace, "is null", value)) | ||
| value is String && !enum.contains(value) -> | ||
| sequenceOf(ValidationError(dataTrace, | ||
| "is not contained in enum [${enum.joinToString(", ")}]", |
There was a problem hiding this comment.
It would be a good idea to create the string version of the enum at construction time so the building of the string doesn't need to happen every request.
|
|
||
| import com.shoprunner.baleen.BaleenType | ||
|
|
||
| abstract class CoercibleType(val type: BaleenType) : BaleenType |
|
|
||
| constructor(enum: Array<out Enum<*>>) : this(enum.map { it.name }) | ||
|
|
||
| override fun name() = "enum" |
There was a problem hiding this comment.
It might be good to require enum types to have a name. That will make the error messages clearer. Could you add a name attribute to the constructor that could be used for the name field and validate method?
| @@ -42,12 +82,23 @@ object AvroEncoder { | |||
| dataDescription.nameSpace, false, fields) | |||
| } | |||
|
|
|||
| fun encode(dataDescription: DataDescription, outputStream: PrintStream) { | |||
| infix fun DataDescription.encodeTo(directory: File): File { | |||
There was a problem hiding this comment.
It would be good if this takes a type mapping function so custom types can be mapped.
There was a problem hiding this comment.
I think you can get the syntax you want without making the function infix. infix functions can only take a single argument.
There was a problem hiding this comment.
Not sure I follow... Can you give an example of how it would look?
|
@HawaiianSpork made the changes as per our conversation |
kdallmeyer-sr
changed the title
Provide a way to generate base Baleen descriptions from legacy Avro schemas. Additionally add the reverse generater from Baleen to Avro.
TODO
WONTDO (Out of scope for now)