<html class="no-js"> #41

suture · 2014-04-16T02:05:55Z

I'm just wondering why this class (no-js) is assigned to the html tag? It seems that Timber doesn't include Modernizer.

Also adding the following line of code in shop.js.liquid doesn't seem to remove the class (no-js)

$('html').removeClass('no-js');

If you check the rendered source, the class remains, even when the browser supports JS.

I've tested it in both Firefox and Safari (the latest versions) on a Mac.

Maybe I misunderstand how it works?

suture · 2014-04-17T03:37:27Z

I think I worked it out.

It's meant to remove the "no-js" class, but this change is only visible in the computed source not "View Source".

Currently the computed source looks like this, which I think must be incorrect.

<html class>

Paul Irish suggests re http://www.paulirish.com/2009/avoiding-the-fouc-v3/

<head>
  <script>(function(H){H.className=H.className.replace(/\bno-js\b/,'js')})(document.documentElement)</script>

cshold · 2014-04-17T13:40:55Z

Don't worry about the conditional comments. You can see in your screenshot that the HTML tag doesn't have any class associated with it. The conditional comments are only valid in IE, and therefore only have the class removed from the tag in those browsers.

cshold mentioned this issue Apr 16, 2014

Js init #42

Merged

cshold closed this as completed in #42 Apr 16, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

<html class="no-js"> #41

<html class="no-js"> #41

suture commented Apr 16, 2014

suture commented Apr 17, 2014

cshold commented Apr 17, 2014

<html class="no-js"> #41

<html class="no-js"> #41

Comments

suture commented Apr 16, 2014

suture commented Apr 17, 2014

cshold commented Apr 17, 2014