Resolves issue #234 with the Quickpay gateway #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Including testmode=1 for recurring message types causes a checksum failure -Recurring message type include a transaction id -The testmode is determined from that reference transaction -Omit the testmode parameter for recurring message types refs activemerchant#234
-add_testmode method should NOT add a testmode parameter to the post hash if a transaction id is present -add_testmode method should add a testmode parameter equal to the test? method if there is no transaction id refs activemerchant#234
|
Added unit tests to verify the intended behavior |
|
+1, we're using this patch on Chargify |
ntalbott
added a commit
that referenced
this pull request
Feb 28, 2012
Don't pass testmode to Quickpay if transaction is specified (closes #324).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Including testmode=1 for recurring message types causes a
checksum failure
-Recurring message types include a transaction id
-The testmode is determined from that reference transaction
-Omit the testmode parameter for recurring message types
resolves #234