Merge pull request #235 from brentmc79/master

Don't pass testmode to Quickpay if transaction is specified (closes #324).
activemerchant · Feb 28, 2012 · d848cac · d848cac
2 parents c37dc1d + 54ce542
commit d848cac
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/active_merchant/billing/gateways/quickpay.rb b/lib/active_merchant/billing/gateways/quickpay.rb
@@ -215,6 +215,7 @@ def add_description(post, options)
       end
 
       def add_testmode(post)
+        return if post[:transaction].present? 
         post[:testmode] = test? ? '1' : '0'
       end
 

diff --git a/test/unit/gateways/quickpay_test.rb b/test/unit/gateways/quickpay_test.rb
@@ -87,6 +87,18 @@ def test_supported_countries
   def test_supported_card_types
     assert_equal  [ :dankort, :forbrugsforeningen, :visa, :master, :american_express, :diners_club, :jcb, :maestro ], QuickpayGateway.supported_cardtypes
   end
+
+  def test_add_testmode_does_not_add_testmode_if_transaction_id_present
+    post_hash = {:transaction => "12345"}
+    @gateway.send(:add_testmode, post_hash)
+    assert_equal nil, post_hash[:testmode]
+  end
+
+  def test_add_testmode_adds_a_testmode_param_if_transaction_id_not_present
+    post_hash = {}
+    @gateway.send(:add_testmode, post_hash)
+    assert_equal '1', post_hash[:testmode]
+  end
 
   private