This repository has been archived by the owner on Jun 13, 2018. It is now read-only.
Fix finding of error description in USPS tracking #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests are just |
|
Well I do have to google xpath. 👍 |
|
👍 |
trishume
added a commit
that referenced
this pull request
May 25, 2015
Fix finding of error description in USPS tracking
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
Fix finding of error description in USPS tracking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code for error message extraction wasn't tested, and was totally wrong.
Code Issues Fixed in this PR
document.elements[...]doesn't search the document, it indexes an array.first_thing || second_thingdoesn't workI'm ashamed that I didn't have to Google the xpath syntax. I try to repress the memories of my days working with XSLT.
@Shopify/shipping