Skip to content
This repository has been archived by the owner on Jun 13, 2018. It is now read-only.

Ups shipment event code #309

Merged
merged 2 commits into from Aug 3, 2015
Merged

Conversation

rsierra
Copy link
Contributor

@rsierra rsierra commented Jul 31, 2015

Parse the type code of each shipment event in tracking response.

@eboswort
Copy link
Contributor

LGTM Guess it's failing on some USPS stuff

@rsierra
Copy link
Contributor Author

rsierra commented Aug 1, 2015

Yeah,but I don't really change nothing for USPS, it's just for UPS. I had no problems with the local unit test, but I forgot the remote ones. I will try to take a look :-).

@eboswort
Copy link
Contributor

eboswort commented Aug 3, 2015

Oh no, I didn't mean to imply you had anything to do with the USPS errors. I feel confident you did not break those.

eboswort added a commit that referenced this pull request Aug 3, 2015
@eboswort eboswort merged commit 2d0249c into Shopify:master Aug 3, 2015
@rsierra
Copy link
Contributor Author

rsierra commented Aug 3, 2015

Ok, thx!

@trishume
Copy link
Contributor

This was released in v1.4.3, thanks for contributing!

maartenvg pushed a commit that referenced this pull request Nov 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants