This repository has been archived by the owner on Jun 13, 2018. It is now read-only.
FedEx: Pass Residential true unless localtion is commerial #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this currently work with Shipwire, USPS and UPS? |
|
UPS submits a residential flag if the address isn't of type commercial. Shipwire, USPS and Canada Post don't submit a residential/commercial flag at all. |
| @@ -218,6 +218,8 @@ module ActiveMerchant | |||
| xml_node << XmlNode.new('Address') do |address_node| | |||
| address_node << XmlNode.new('PostalCode', location.postal_code) | |||
| address_node << XmlNode.new("CountryCode", location.country_code(:alpha2)) | |||
|
|
|||
| address_node << XmlNode.new("Residential", true) unless location.commercial? || !location.company_name.blank? | |||
There was a problem hiding this comment.
I think this should probably only be basing the Residential status on the address_type, and not the company name as well. Users of the library can make that decision on their own.
address_node << XmlNode.new("Residential", !location.commercial?)
There was a problem hiding this comment.
updated to only add the node if the location type is commercial
|
LGTM |
isaac
pushed a commit
to isaac/active_shipping
that referenced
this pull request
Oct 20, 2011
kknd113
pushed a commit
to dotandbo/active_shipping
that referenced
this pull request
May 12, 2015
kknd113
pushed a commit
to dotandbo/active_shipping
that referenced
this pull request
May 12, 2015
…culator [Fixes Shopify#31] Missing USPS First Class Mail
maartenvg
pushed a commit
that referenced
this pull request
Oct 8, 2017
maartenvg
pushed a commit
that referenced
this pull request
Oct 12, 2017
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@odorcicd @jaw6 for codereview