Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already initialized constant COUNTRIES #43

Closed
morgoth opened this issue Sep 10, 2014 · 1 comment
Closed

Already initialized constant COUNTRIES #43

morgoth opened this issue Sep 10, 2014 · 1 comment

Comments

@morgoth
Copy link

morgoth commented Sep 10, 2014

After upgradng active_merchant to 1.44.1 and adding offsite_payments to my Gemfile I'm getting warnings:

/home/wojtek/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/active_utils-2.2.3/lib/active_utils/common/country.rb:65: warning: already initialized constant ActiveMerchant::Country::COUNTRIES
/home/wojtek/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/activemerchant-1.44.1/lib/active_merchant/country.rb:62: warning: previous definition of COUNTRIES was here

As you can see it is defined in both gems:

https://github.com/Shopify/active_merchant/blob/master/lib/active_merchant/country.rb#L67
https://github.com/Shopify/active_utils/blob/master/lib/active_utils/common/country.rb#L65

@wvanbergen
Copy link
Contributor

This has been fixed on master, however, this is a breaking change that will be a major release (3.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants