Split Comparison Helper #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloydsal
force-pushed
the
remove-comparison-helper
branch
from
ed11e74
to
01d3d43
Compare
kwiersema
approved these changes
Feb 1, 2024
| sig { params(address: AbstractAddress, candidate: Candidate, datastore: DatastoreBase).void } | ||
| def initialize(address:, candidate:, datastore:) | ||
| @comparison_helper = ComparisonHelper.new(address:, candidate:, datastore:) | ||
| @street_comparison = StreetComparison.new(address: address, candidate: candidate, datastore: datastore) |
| # typed: true | ||
| # frozen_string_literal: true | ||
|
|
||
| module AtlasEngine |
| end | ||
|
|
||
| sig { params(candidate: Candidate).returns(T::Array[AddressNumberRange]) } | ||
| def building_ranges_from_candidate(candidate) |
There was a problem hiding this comment.
I think this could be moved into the BuildingComparison class, since that is the only subclass which requires it.
lloydsal
force-pushed
the
remove-comparison-helper
branch
from
01d3d43
to
fddb02f
Compare
3 tasks
lloydsal
force-pushed
the
remove-comparison-helper
branch
from
fddb02f
to
3508078
Compare
lloydsal
force-pushed
the
remove-comparison-helper
branch
from
3508078
to
90bc359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ComparisonHelper is mainly running different field comparisons under methods in the same class. This prevents us from adding flexibility to individual field comparison logic.
This is step 1 of the logic to make the comparison classes configurable by country.
In step 2 we will attempt to simplify the comparison logic to remove the need for external classes to interact with
Token::Sequence::ComparisonApproach
This is a simple refactor and does not bring any change to the logic.
Testing
Checklist