Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failures when non-exact Ruby version specified in Gemfile #55

Merged
merged 4 commits into from
Jan 25, 2023
Merged

fix failures when non-exact Ruby version specified in Gemfile #55

merged 4 commits into from
Jan 25, 2023

Conversation

ashkulz
Copy link
Contributor

@ashkulz ashkulz commented Jan 16, 2023

fixes #50

@ashkulz
Copy link
Contributor Author

ashkulz commented Jan 16, 2023

@rafaelfranca, should I update README.md as well? I'm not sure it's required tbh 🤔

@ashkulz
Copy link
Contributor Author

ashkulz commented Jan 18, 2023 •
edited

@nvasilevski you seem to have merged recent PRs, not sure if you can review this?

nvasilevski
nvasilevski reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@nvasilevski nvasilevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for tackling it!
Sorry I'm not very familiar with internals so had to ask some clarifying questions.
Let's add an entry to the CHANGELOG as it's a bugfix.
Also there are a few rubocop failures

test/bootboot_test.rb Outdated Show resolved Hide resolved
test/bootboot_test.rb Show resolved Hide resolved
test/bootboot_test.rb Outdated Show resolved Hide resolved
lib/bootboot/bundler_patch.rb Outdated Show resolved Hide resolved
lib/bootboot/ruby_source.rb Outdated Show resolved Hide resolved
@ashkulz
Copy link
Contributor Author

ashkulz commented Jan 25, 2023

@nvasilevski addressed all PR feedback, hope that it's good to merge 👍

@nvasilevski
Copy link
Contributor

Thank you! I'll release the fix soon

@nvasilevski nvasilevski merged commit d4a5b1e into Shopify:main Jan 25, 2023
@adamstegman adamstegman mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvasilevski nvasilevski nvasilevski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby version issues
2 participants
@ashkulz @nvasilevski