Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@grosser @jules2689
This should bail out of the iseq caching early enough. Testing whether the constant is defined is very fast. This should add less than 2ms to shopify boot.
Where this falls down is if coverage is eager-loaded by something, but not actually used.
The only ruby-land API available to us to test whether coverage is actually running is
Coverage.peek_result
, which appears to be quite expensive if coverage is currently running. I think that's unviable. I wonder if we can add a little function to the C extension to check this more economically.