Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for windows 8.1 #5

Merged
merged 2 commits into from
Feb 24, 2014
Merged

Add support for windows 8.1 #5

merged 2 commits into from
Feb 24, 2014

Conversation

gmalette
Copy link
Contributor

Not sure wether Windows 8.1 should register as 8 or 8.1

@gmalette
Copy link
Contributor Author

ping @qq99

Who can push this to rubygems? @xthexder

@qq99
Copy link
Contributor

qq99 commented Feb 24, 2014

No clue, afaik we haven't in a long while
LGTM 👍

@xthexder
Copy link
Contributor

I'd say register it as Windows 8.1, 👍

@samuelkadolph can push this to rubygems

@gmalette
Copy link
Contributor Author

I'll bamp to 1.0.4

gmalette added a commit that referenced this pull request Feb 24, 2014
Add support for windows 8.1
@gmalette gmalette merged commit 0a87af3 into master Feb 24, 2014
@gmalette gmalette deleted the windows-8.1 branch February 24, 2014 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants