Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nexus support (Nexus 5, Nexus 7 & Nexus 10) #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EsKuel
Copy link

@EsKuel EsKuel commented Jun 10, 2014

Hi !

Nexus 10 and 7 are missing in patterns file so the gem currently recognise them as handheld device.
I also add Nexus 5 in pattern file to add the whole family :)

@carsonb
Copy link
Contributor

carsonb commented Jul 11, 2014

Hi there! Thanks so much for the PR.

I think browser sniffer is being far too picky about what's a handheld and what's a tablet. Android docs from the distant past talk about it being the presence of "Mobile" defining handhelds, and the lack of it defining tablets: http://android-developers.blogspot.ca/2010/12/android-browser-user-agent-issues.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants