Add TestTimeRecord #113
Merged
Add TestTimeRecord #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicaxiejw
force-pushed
the
add_test_time_record
branch
from
383c948
to
fb752e5
Compare
sander-m
reviewed
Nov 20, 2019
Comment on lines
55
to
61
| def key_to_list_all_test_names | ||
| "build:#{config.build_id}:list_of_test_names".force_encoding(Encoding::BINARY) | ||
| end | ||
|
|
||
| def test_time_key(test_name) | ||
| "build:#{config.build_id}:#{test_name}".force_encoding(Encoding::BINARY) | ||
| end |
There was a problem hiding this comment.
The method names test_time_key and key_to_list_all_test_names are somewhat inconsistent.
sander-m
reviewed
Nov 20, 2019
| redis = Redis.new(url: redis_url) | ||
| redis.flushdb | ||
|
|
||
| config ||= CI::Queue::Configuration.new( |
sander-m
reviewed
Nov 20, 2019
Comment on lines
+5
to
+7
| redis_url = "redis://#{ENV.fetch('REDIS_HOST', 'localhost')}/7" | ||
| redis = Redis.new(url: redis_url) | ||
| redis.flushdb |
There was a problem hiding this comment.
Nitpick: this same pattern is used in multiple places, it would be nice to move this into a test helper module that any test can include if it needs a local Redis instance (more DRY). Feel free to ignore this for this PR.
There was a problem hiding this comment.
good idea, I'll add it in a separate PR.
There was a problem hiding this comment.
Can you create an issue for that and add it to the kanban board, so that this doesn't get lost?
There was a problem hiding this comment.
good idea, issue created: #114
doodzik
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the class to store the run time of individual test during a grind in Redis.
Related https://github.com/Shopify/test-infra/issues/36
You can see the entire change at https://github.com/Shopify/ci-queue/pull/112/files