Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize bisect queue after loading tests #273

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

zarifmahfuz
Copy link
Contributor

Follow-up on #272. We're going clean the test order file given to bisect from the client side instead. Specifically from the file which loads all the tests. We're going to introspect the currently existing tests based on what's available in Minitest::Test.runnables. To make sure that ci-queue reads the cleaned test order file, we need to initialize the bisect queue after it runs load_tests.

@zarifmahfuz zarifmahfuz requested a review from a team April 23, 2024 01:29
Copy link
Contributor

@ChrisBr ChrisBr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to flip the order slightly.

@zarifmahfuz zarifmahfuz merged commit df3a48f into main Apr 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants