Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #63 by ignoring left and right keypresses #64

Merged
merged 1 commit into from Mar 31, 2019
Merged

Fixes #63 by ignoring left and right keypresses #64

merged 1 commit into from Mar 31, 2019

Conversation

cFire
Copy link
Contributor

@cFire cFire commented Mar 31, 2019

Implemented simple fix by just having the left and right key inputs ignored so they don't drop into the else clause where an exception is raised.

@ghost ghost added the cla-needed label Mar 31, 2019
@cFire
Copy link
Contributor Author

cFire commented Mar 31, 2019

CLA signed.

@ghost ghost removed the cla-needed label Mar 31, 2019
@lugray lugray merged commit 8fa2293 into Shopify:master Mar 31, 2019
@lugray
Copy link
Contributor

lugray commented Mar 31, 2019

Thanks!

@lavoiesl lavoiesl temporarily deployed to production August 14, 2019 17:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cFire @lugray @lavoiesl