Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopify asset_url filter not working on local and resolves to /assets instead on the shopify CDN leading to 404s #2096

Closed
2 tasks done
merziy opened this issue Jun 5, 2023 · 10 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@merziy
Copy link

merziy commented Jun 5, 2023

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Function, Theme, Other

Expected behavior

Files with the asset_url filter using Shopify CLI version 3.46.2 should resolve over the Shopify CDN

Actual behavior

Files with the asset_url filter using Shopify CLI version 3.46.2 on two different projects, but not all, are resolving as {myshopifysite}.myshopify.com/assets/{asset-name}.css?v=139638057495805369281685991684, which leads to 404s in the console, instead of being delivered over the CDN as something like {myshopifysite}.myshopify.com/cdn/shop/files/{asset-name}.

Verbose output

shopify theme dev --verbose

2023-06-05T19:27:07.864Z: Running command theme dev
  shopify:theme:dev init version: @oclif/core@2.1.4 argv: [ '--verbose' ] +0ms
2023-06-05T19:27:07.876Z: Ensuring that the user is authenticated with the Theme API with the following scopes:
[]

2023-06-05T19:27:07.876Z: Ensuring that the user is authenticated with the Admin API with the following scopes for the store kareehays-esthetics.myshopify.com:
[]

2023-06-05T19:27:07.876Z: Getting session store...
2023-06-05T19:27:07.877Z: Validating existing session against the scopes:
[
  "openid",
  "https://api.shopify.com/auth/shop.admin.graphql",
  "https://api.shopify.com/auth/shop.admin.themes",
  "https://api.shopify.com/auth/partners.collaborator-relationships.readonly",
  "https://api.shopify.com/auth/shop.storefront-renderer.devtools",
  "https://api.shopify.com/auth/partners.app.cli.access"
]
For applications:
{
  "adminApi": {
    "scopes": [],
    "storeFqdn": "kareehays-esthetics.myshopify.com"
  }
}

2023-06-05T19:27:07.878Z: Sending Identity Introspection request to URL: https://accounts.shopify.com/oauth/introspection
2023-06-05T19:27:07.878Z: Sending POST request to URL https://accounts.shopify.com/oauth/introspection
With request headers:
 - User-Agent: Shopify CLI; v=3.46.2
 - Keep-Alive: timeout=30
 - Sec-CH-UA-PLATFORM: darwin
 - Content-Type: application/json

2023-06-05T19:27:07.964Z: Request to https://accounts.shopify.com/oauth/introspection completed in 82 ms
With response headers:
 - cache-control: no-cache
 - content-type: text/html
 - x-request-id: 25a8f812-c0a6-4f60-9d4a-105976765c25

2023-06-05T19:27:07.965Z: The Introspection request failed with:
 - status: 401
 - www-authenticate header: "error=\"invalid_token\",error_description=\"The access token provided is expired, revoked, malformed or invalid for other reasons.\""
 - body: ""
2023-06-05T19:27:07.966Z:
The validation of the token for application/identity completed with the following results:
- It's expired: false
- It's invalid in identity: true

2023-06-05T19:27:07.966Z: Initiating the full authentication flow...
2023-06-05T19:27:07.966Z: Authorizing through Identity's website...

To run this command, log in to Shopify Partners.
👉 Press any key to open the login page on your browser
2023-06-05T19:27:14.674Z: Reading the content of file at /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/success.html...
2023-06-05T19:27:14.706Z: Reading the content of file at /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/style.css...
2023-06-05T19:27:14.742Z: Reading the content of file at /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/favicon.svg...
2023-06-05T19:27:15.185Z: Authorization code received. Exchanging it for a CLI token...
2023-06-05T19:27:15.187Z: Sending POST request to URL https://accounts.shopify.com/oauth/token?grant_type=authorization_code&code=e23d5a69452cc2c45a1ba2cef1fe333ea9fc08864e68af87d4a9dd89ed782167&redirect_uri=http%3A%2F%2F127.0.0.1%3A3456&client_id=fbdb2649-e327-4907-8f67-908d24cfd7e3&code_verifier=ZYdMAiyueXPO806A_rIbFL675A889W-umepcHV5Qh0I
With request headers:
 - User-Agent: Shopify CLI; v=3.46.2
 - Keep-Alive: timeout=30
 - Sec-CH-UA-PLATFORM: darwin
 - Content-Type: application/json

2023-06-05T19:27:15.451Z: Request to https://accounts.shopify.com/oauth/token?grant_type=authorization_code&code=e23d5a69452cc2c45a1ba2cef1fe333ea9fc08864e68af87d4a9dd89ed782167&redirect_uri=http%3A%2F%2F127.0.0.1%3A3456&client_id=fbdb2649-e327-4907-8f67-908d24cfd7e3&code_verifier=ZYdMAiyueXPO806A_rIbFL675A889W-umepcHV5Qh0I completed in 260 ms
With response headers:
 - cache-control: no-cache, no-store, private, must-revalidate, max-age=0
 - content-type: application/json; charset=utf-8
 - etag: W/"c68517ecd8208433a0a68e1ed9dd91a2"
 - x-request-id: 5ffa6144-0401-431e-af59-9b30ae651b7a

2023-06-05T19:27:15.456Z: CLI token received. Exchanging it for application tokens...
2023-06-05T19:27:15.457Z: Sending POST request to URL https://accounts.shopify.com/oauth/token?grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange&requested_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&client_id=fbdb2649-e327-4907-8f67-908d24cfd7e3&audience=271e16d403dfa18082ffb3d197bd2b5f4479c3fc32736d69296829cbb28d41a6&scope=openid+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fpartners.app.cli.access&subject_token=atkn_c70c9ed4fbbd76bf3882cdadfec9c7d149d860c926da0f38b53581d90f995990
With request headers:
 - User-Agent: Shopify CLI; v=3.46.2
 - Keep-Alive: timeout=30
 - Sec-CH-UA-PLATFORM: darwin
 - Content-Type: application/json

2023-06-05T19:27:15.457Z: Sending POST request to URL https://accounts.shopify.com/oauth/token?grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange&requested_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&client_id=fbdb2649-e327-4907-8f67-908d24cfd7e3&audience=ee139b3d-5861-4d45-b387-1bc3ada7811c&scope=openid+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fshop.storefront-renderer.devtools&subject_token=atkn_c70c9ed4fbbd76bf3882cdadfec9c7d149d860c926da0f38b53581d90f995990
With request headers:
 - User-Agent: Shopify CLI; v=3.46.2
 - Keep-Alive: timeout=30
 - Sec-CH-UA-PLATFORM: darwin
 - Content-Type: application/json

2023-06-05T19:27:15.612Z: Request to https://accounts.shopify.com/oauth/token?grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange&requested_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&client_id=fbdb2649-e327-4907-8f67-908d24cfd7e3&audience=ee139b3d-5861-4d45-b387-1bc3ada7811c&scope=openid+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fshop.storefront-renderer.devtools&subject_token=atkn_c70c9ed4fbbd76bf3882cdadfec9c7d149d860c926da0f38b53581d90f995990 completed in 152 ms
With response headers:
 - cache-control: no-cache, no-store, private, must-revalidate, max-age=0
 - content-type: application/json; charset=utf-8
 - etag: W/"e5338cf384093e9bc1c236ba53aee98c"
 - x-request-id: f98daa81-245b-46bd-9d27-ea574dc5fe5c

2023-06-05T19:27:15.872Z: Request to https://accounts.shopify.com/oauth/token?grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange&requested_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&client_id=fbdb2649-e327-4907-8f67-908d24cfd7e3&audience=271e16d403dfa18082ffb3d197bd2b5f4479c3fc32736d69296829cbb28d41a6&scope=openid+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fpartners.app.cli.access&subject_token=atkn_c70c9ed4fbbd76bf3882cdadfec9c7d149d860c926da0f38b53581d90f995990 completed in 412 ms
With response headers:
 - cache-control: no-cache, no-store, private, must-revalidate, max-age=0
 - content-type: application/json; charset=utf-8
 - etag: W/"7f402d2876ffdda15a24237af6edb8fe"
 - x-request-id: 86dbfc50-2edf-40ea-90af-cf3e9894f4df

2023-06-05T19:27:15.890Z: Sending POST request to URL https://accounts.shopify.com/oauth/token?grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange&requested_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&client_id=fbdb2649-e327-4907-8f67-908d24cfd7e3&audience=7ee65a63608843c577db8b23c4d7316ea0a01bd2f7594f8a9c06ea668c1b775c&scope=openid+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fshop.admin.graphql+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fshop.admin.themes+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fpartners.collaborator-relationships.readonly&subject_token=atkn_c70c9ed4fbbd76bf3882cdadfec9c7d149d860c926da0f38b53581d90f995990&destination=https%3A%2F%2Fkareehays-esthetics.myshopify.com%2Fadmin
With request headers:
 - User-Agent: Shopify CLI; v=3.46.2
 - Keep-Alive: timeout=30
 - Sec-CH-UA-PLATFORM: darwin
 - Content-Type: application/json

2023-06-05T19:27:16.058Z: Request to https://accounts.shopify.com/oauth/token?grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange&requested_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&client_id=fbdb2649-e327-4907-8f67-908d24cfd7e3&audience=7ee65a63608843c577db8b23c4d7316ea0a01bd2f7594f8a9c06ea668c1b775c&scope=openid+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fshop.admin.graphql+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fshop.admin.themes+https%3A%2F%2Fapi.shopify.com%2Fauth%2Fpartners.collaborator-relationships.readonly&subject_token=atkn_c70c9ed4fbbd76bf3882cdadfec9c7d149d860c926da0f38b53581d90f995990&destination=https%3A%2F%2Fkareehays-esthetics.myshopify.com%2Fadmin completed in 166 ms
With response headers:
 - cache-control: no-cache, no-store, private, must-revalidate, max-age=0
 - content-type: application/json; charset=utf-8
 - etag: W/"9464aabff269399a90b6eaef0595922f"
 - x-request-id: 484f71d9-7fa1-4fc2-847a-de9a872c2190

✔ Logged in.
2023-06-05T19:27:16.061Z: Setting session store...
2023-06-05T19:27:16.071Z: Ensuring that the user is authenticated with the Storefront API with the following scopes:
[]

2023-06-05T19:27:16.071Z: Getting session store...
2023-06-05T19:27:16.076Z: Validating existing session against the scopes:
[
  "openid",
  "https://api.shopify.com/auth/shop.admin.graphql",
  "https://api.shopify.com/auth/shop.admin.themes",
  "https://api.shopify.com/auth/partners.collaborator-relationships.readonly",
  "https://api.shopify.com/auth/shop.storefront-renderer.devtools",
  "https://api.shopify.com/auth/partners.app.cli.access"
]
For applications:
{
  "storefrontRendererApi": {
    "scopes": []
  }
}

2023-06-05T19:27:16.077Z: Sending Identity Introspection request to URL: https://accounts.shopify.com/oauth/introspection
2023-06-05T19:27:16.078Z: Sending POST request to URL https://accounts.shopify.com/oauth/introspection
With request headers:
 - User-Agent: Shopify CLI; v=3.46.2
 - Keep-Alive: timeout=30
 - Sec-CH-UA-PLATFORM: darwin
 - Content-Type: application/json

2023-06-05T19:27:16.200Z: Request to https://accounts.shopify.com/oauth/introspection completed in 120 ms
With response headers:
 - cache-control: no-cache, no-store, private, must-revalidate, max-age=0
 - content-type: application/json; charset=utf-8
 - etag: W/"4df4ee2f0cd0e5821c4229ceb2d40566"
 - x-request-id: 195f5c0c-e087-432b-9307-caa0be017e97

2023-06-05T19:27:16.202Z: The identity token is valid: true
2023-06-05T19:27:16.202Z:
The validation of the token for application/identity completed with the following results:
- It's expired: false
- It's invalid in identity: false

2023-06-05T19:27:16.211Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/ruby -v
  · Working directory: /Users/alexandermathis/dev/juicyorange/karee-hays-esthetics-final

2023-06-05T19:27:16.228Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle -v
  · Working directory: /Users/alexandermathis/dev/juicyorange/karee-hays-esthetics-final

2023-06-05T19:27:16.331Z: Reading the content of file at /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby/Gemfile...
2023-06-05T19:27:16.332Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle config set --local path /Users/alexandermathis/Library/Caches/shopify-gems-nodejs
  · Working directory: /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby

2023-06-05T19:27:16.411Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle config set --local without development:test
  · Working directory: /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby

2023-06-05T19:27:16.490Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle install
  · Working directory: /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby

2023-06-05T19:27:16.640Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle exec /opt/homebrew/opt/ruby/bin/ruby /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby/bin/shopify theme token --admin atkn_eyJhbGciOiJSUzI1NiIsImtpZCI6Ik4teW1MUDR5TWt2MlR2X3hjWkNNSlltZ2JDbjhQbm5WLWRBbUJHbTlHb3cifQ.eyJ0IjoidXFFUXdEWEZPb3lsNDJoMXEvbjZRekhkYkN4azVrcmZMOGxWQUlubUpZaz0ifQ.YuUXBn1qrsplQTJihXunVMIg2M607zW__QKaFv3vwRMZqoeQhFlmvqw6_C6iyN2edyDWpo6LB8f7HMJw7uAugl54UTz2nmrLxB9Eq0ajiowqSPGtvLvseCpFHlCowxSsWWk8nlPPDQ9egzaS4xJ2g_vscfEKmY2uI26IXaTs5p9AHo3C_qOu70Kz_th9GSkXatHx0W0c-weOC3TvhtuKtW1j2c_AKwMxvTP5iw8hGJwxmbRkOLLjOnE7CJIlMr2eUootpXK08GjhX9ikJa3yBTcsakcjTlGPgn7ay-cMLHRro8N7ALec3IIypJ5WfQeIDKB68tSVwoSPzwvd1jHCSA --sfr atkn_eyJhbGciOiJSUzI1NiIsImtpZCI6Ik4teW1MUDR5TWt2MlR2X3hjWkNNSlltZ2JDbjhQbm5WLWRBbUJHbTlHb3cifQ.eyJ0IjoiSElsRDRHTWRSYVZqV2t5MnFwcXIzQjhyOUlCQTBYK3hVRDJvZmUxNXoxTT0ifQ.k8EGJmw6Ar1CwmV_D05oOyVkd2zLTxfDJKDdJEuxNXVkAhRXkZ6Bmr5PfVWm7zd5koedbq_N0ARKakRVB2iAH9cWfIp0QBR7NJ8nzyYZNQv05qV_vJBIXzCmFZkb_PXQkn18gW4X9KfLl2s16MPLVBRy5fqiDt21fU7ForreqS5ft3mtLYRX4Sf8LrLDz11w7Xj8X-jhFHWpk3DZh5arhTBqfXqHcSv6EGs8BOkpIVME5wYuZU4orlCU1ALzyYgXLEkkNnbayekaSZs1jL0YS2S_dxg8Eia3XkMLFYqMg2TVU1JYIukN5rL7iHUOJcFMEjOfDRLHaIMNPLTbacrsjQ
  · Working directory: /Users/alexandermathis/dev/juicyorange/karee-hays-esthetics-final

2023-06-05T19:27:16.888Z: Getting development theme...
2023-06-05T19:27:17.290Z: Request to https://kareehays-esthetics.myshopify.com/admin/api/unstable/themes/149719613757.json?fields=id completed in 400 ms
With response headers:
 - content-type: application/json; charset=utf-8
 - x-request-id: 53c8d9d6-5ba3-4884-8fff-b1bf2bd8d833

╭─ success ────────────────────────────────────────────────────────────────────╮
│                                                                              │
│  Preview your theme                                                          │
│    • http://127.0.0.1:9292                                                   │
│                                                                              │
│  Next steps                                                                  │
│    • Customize your theme at the theme editor                                │
│    • Share your theme preview                                                │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

2023-06-05T19:27:17.345Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/ruby -v
  · Working directory: /Users/alexandermathis/dev/juicyorange/karee-hays-esthetics-final

2023-06-05T19:27:17.354Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle -v
  · Working directory: /Users/alexandermathis/dev/juicyorange/karee-hays-esthetics-final

2023-06-05T19:27:17.433Z: Reading the content of file at /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby/Gemfile...
2023-06-05T19:27:17.434Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle config set --local path /Users/alexandermathis/Library/Caches/shopify-gems-nodejs
  · Working directory: /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby

2023-06-05T19:27:17.512Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle config set --local without development:test
  · Working directory: /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby

2023-06-05T19:27:17.590Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle install
  · Working directory: /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby

2023-06-05T19:27:17.740Z:
Running system process:
  · Command: /opt/homebrew/opt/ruby/bin/bundle exec /opt/homebrew/opt/ruby/bin/ruby /opt/homebrew/Cellar/shopify-cli/3.46.2/libexec/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby/bin/shopify theme serve /Users/alexandermathis/dev/juicyorange/karee-hays-esthetics-final --live-reload hot-reload --theme 149719613757
  · Working directory: /Users/alexandermathis/dev/juicyorange/karee-hays-esthetics-final

DEBUG GET https://kareehays-esthetics.myshopify.com/admin/api/unstable/themes.json with request_id: 7e3685e0-57dc-42e0-8e0d-9e1c3a6ce130
* Syncing theme #149719613757 on kareehays-esthetics.myshopify.com
DEBUG GET https://kareehays-esthetics.myshopify.com/admin/api/unstable/themes/149719613757/assets.json with request_id: d2771543-0fdc-41e3-8392-523506fe09cc
                                                                                          100%
[2023-06-05 15:27:18] INFO  WEBrick 1.7.0
[2023-06-05 15:27:18] INFO  ruby 3.2.2 (2023-03-30) [arm64-darwin22]
[2023-06-05 15:27:18] INFO  WEBrick::HTTPServer#start: pid=60387 port=9292
DEBUG Refreshing preview _secure_session_id cookie
DEBUG Proxying HEAD https://kareehays-esthetics.myshopify.com/?preview_theme_id=149719613757&_fd=0&pb=0
DEBUG `-> 302 request_id: 3ee78e0f-8f36-4ef0-a25a-a9c5d86d32ca
DEBUG Proxying GET https://kareehays-esthetics.myshopify.com/?_fd=0&pb=0
DEBUG `-> 200 request_id: bac1c104-16c8-4e54-a25c-03d9e7cf5f87
DEBUG Proxying GET https://kareehays-esthetics.myshopify.com/cdn/shop/t/10/compiled_assets/scripts.js?3605=&_fd=0&pb=0
DEBUG `-> 200 request_id: 43e52601-1ffe-4b0f-8935-d5d8e78f70c3
DEBUG [HotReload] Connected to SSE stream

Reproduction steps

  1. Run shopify theme dev --store my-store.myshopify.com
  2. Make a change to an asset and see how the CLI does sync and detect the change, which you can also view in the browser
  3. Inspect assets that are giving 404 errors and notice they are being delivered as {myshopifysite}.myshopify.com/assets/{asset-name} instead of {myshopifysite}.myshopify.com/cdn/shop/files/{asset-name}

Operating System

Mac OS 13.4 (22F66)

Shopify CLI version (check your project's package.json if you're not sure)

3.46.2

Shell

zsh

Node version (run node -v if you're not sure)

v20.2.0

What language and version are you using in your application?

Liquid, Javascript

@merziy merziy added the Type: Bug Something isn't working label Jun 5, 2023
@evilzebra-labs
Copy link

evilzebra-labs commented Jun 6, 2023

hey @merziy
I'm encountering a similar problem, but it's only affecting one of the stores I'm working on.
This bug was actually reported over a month ago, and unfortunately, it has prevented me from making progress on implementing the store's new features.

You can see the bug report here: #1859

@merziy
Copy link
Author

merziy commented Jun 6, 2023

@evilzebra-labs Thanks for letting me know this isn't isolated or some environment issue, i've actually had this problem for a month or so as well but it wasn't a priority until now.

@evilzebra-labs
Copy link

@merziy no worries... I checked the latest bug reports... and it looks like a lot of people are facing the same issue...
#2094
#1974
#1859

The weird thing is it happens only in some stores, and others work just fine.

And the same is happening to me.. it wasn't a BIG priority until now...
My client is pushing to finish the new features and it's not something I can just do on the theme editor

@karreiro karreiro self-assigned this Jun 6, 2023
@max-commercetheory
Copy link

Same issue here. Rolling back to previous CLI versions has not solved the issue either. This is impacting one store, with a now impatient client.

@karreiro
Copy link
Contributor

karreiro commented Jun 7, 2023

Thank you, everyone, for reporting this and sharing those details. The issue has been resolved through #2105 and will be included in the next release of the CLI.

@karreiro karreiro closed this as completed Jun 7, 2023
@amcaplan
Copy link
Contributor

amcaplan commented Jun 7, 2023

CLI version 3.46.3 has been released, including the fix. Thanks @karreiro for making it happen.

Folks, please update to the latest and let us know if you continue to encounter any issues. Thanks as always for your input!

@EricMainhard
Copy link

@amcaplan I have updated my CLI to the last version 3.47.2 and error is still happening :(

@amcaplan
Copy link
Contributor

amcaplan commented Jul 2, 2023

FYI @karreiro ⬆️

@karreiro
Copy link
Contributor

karreiro commented Jul 5, 2023

@EricMainhard, this issue shouldn't happen on 3.47.2 indeed, could you please follow the steps below to help us better understand the scenario you're facing?

  1. Run shopify theme dev --verbose

  2. Capture a screenshot that displays both the terminal and network logs, similar to the example provided below:

    Screenshot 2023-06-08 at 16 10 48

With that information we can gain more context regarding the issue you're facing and fix it.

Thank you for reporting that!

@jbwhaley-pr
Copy link

This is still happening on 3.49.7. Unfortunately this bug makes doing theme development impossible on the platform.

Given history and experience I think we can all just expect this to be a problem forever. Enjoy your jobs, everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants