-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: issue with running npm run deploy. #2626
Comments
Hi! I'm not able to reproduce it. I guess you just have an app with a Delivery Customization function in JS, right? Could you please go to your extension folder and run these commands?
Does it work if you create a new app with a new extension? |
no, it will have the same issue. |
That's weird. Could you try this?
If it keeps failing, then could you share the outputs of these commands?
|
Following on from the above. Experiencing the same issue on just running
|
Thanks to @gonzaloriestra the problem was solved, I think it's related to different versions of javy being installed, I just removed what you have mentioned above. and in my case, I also had to remove I think it's safe to close this issue. |
Issue still occurring for me, possibly @hailong111 too? |
@jeffcharles @saulecabrera @surma javy is apparently doing nothing here. Any clue? Is there a way to show verbose outputs or check the logs? Thanks! |
This is puzzling me! This really shouldn’t be happening, but I can’t reproduce it either locally, so I’ll follow a hunch and take a stab in the dark. Sorry to give you the runaround @mdenoronha! Can you do me a favor and run |
Happy to keep trying, got a Plus store here keen to get it working. |
One thing that is unexpected for me is that there's an
I'm not 100% sure what the behaviour of For context, the To add some extra confusion, version I suspect that whatever is specifying |
Had a look, I believe the |
It's unexpected to me that moving the input path argument to right after All four of:
work for me. That said, it's interesting that that fixed your issue. I'd like to understand why it did. Can you clarify by what you meant in #2626 (comment) with:
Is the The reason I ask is I suspect this is referring to the |
@mahdi-akbary comment mentioned about Javy versions, so tried My mistake, I installed const args = ['compile', 'dist/function.js','-d', '-o', fun.outputPath, ...extra]
return exec('javy', args, {
cwd: fun.directory,
stdout: 'inherit',
stderr: 'inherit',
signal: options.signal,
}); It worked, but then assumed the order of directories was the issue, so updated args to be It's actually uninstalled now and it's not working. Although, I've just installed globally again and still not working so not too sure here. |
Yeah, It was just Not overly helpful, but I guess I'd mention as a workaround for anyone else with this issue until this is addressed . |
If the
This is interesting. I'll take a look at the impact of using different Node versions. Thanks! |
I ran:
with Node 18.12.0 and all four invocations worked. |
Oh yeah, can ignore that Node version point, The store it's being implemented for obviously don't mind this workaround. I guess it just waiting on that alternative fix to be implemented on the |
Okay, that aligns with my understanding. I think the fix is changing that |
@jeffcharles thanks a lot for your help! Before preparing a fix, @mdenoronha could you please uninstall the global javy and try this from the app root?
|
Same response, just exit code is now |
Hmm, could you run these ones?
|
Both |
What's the output of:
What's your operating system? Are you also using MacOS Ventura? If you're on a Mac, can you run:
If you're using Linux, can you run:
If you're using Windows, can you run:
|
Node Mac Ventura 13.2.1 Getting |
Okay. I would advise updating the project's Can you run |
|
Glad to hear that worked! Sounds like the I looked into it and it looks like |
I see it has been already updated here and included in v3.48.1. So I guess a simple CLI upgrade would have been enough here... 😅 So I'm closing, since everything looks good now. Thank you everyone for the feedback and help. |
Hi this issue again arrive , i am having the same issue when i try to run my app . Error coming from Command failed with exit code 1: npm exec -- javy --version |
Please help me this , i have urgent update on my app . |
@Vijendra2016 Do you have the latest CLI version? Otherwise, could you try some of the things above to try to find out what's going on? I'd start with this: #2626 (comment) |
@gonzaloriestra i have latest version of cli. |
i even installed the node and reinstalled latest version of node but i still facing same issue. |
Error coming from I follow same steps you mension previously but it not work. same error i facing |
Could you please follow the conversation here and post the outputs of the several suggested commands? |
I follow all i still get same error , can anyone give me way to fix this . |
In order to investigate, we need more information, like:
|
Reproduction steps - When i create new app Outputs from the suggested commands above Error coming from Command failed with exit code 1: npm exec -- javy --version ──────────────────────────────────────────────────────────────────────────────── |
When i run my app npm run dev or pnpm dev Error coming from npm exec -- javy --version Command failed with exit code 1: npm exec -- javy --version |
this error i conunter last week , everthing was working fine before |
This Issure is resolve i delete all javy files in r %HOME%\AppData\Local\binarycache\ |
Great, so it was solved by my first suggestion. |
Please confirm that you have:
In which of these areas are you experiencing a problem?
Function
Expected behavior
It should work without error and can deploy it.
Actual behavior
The main error is : Error coming from
npm exec -- javy compile -d -o /Users/Mao/Development/Shopify-function-app/apps/extensions/shipping-rate/dist/function.wasm dist/function.js
And it does not have file function_wasm dist/function.js in the dist folder, which only has function.js.
The verbose running result:
Reproduction steps
Operating System
MacOS ventura 13.0.1
Shopify CLI version (check your project's
package.json
if you're not sure)3.48.0
Shell
No response
Node version (run
node -v
if you're not sure)v20.4.0
What language and version are you using in your application?
No response
The text was updated successfully, but these errors were encountered: