Bump minimum ruby version requirement #3818
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codlp
changed the title
karreiro
approved these changes
May 1, 2024
There was a problem hiding this comment.
Thank you for this PR, @codlp! It looks great to me, I just believe we need to get the CLA check passing :)
@isaacroldan, I've added you as a reviewer because I'm not sure how the lifecycle of the generated_static_pages.json works. I wonder if it can be updated here, or if it should be updated somewhere else and auto-synced in the CLI repository.
|
@karreiro The docs are still not automated, so after merging this we need to open a PR to the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #3816
Currently, the Shopify CLI's documentation indicates that, to work with themes, we need to have ruby version 2.7.2 or higher.
However, with ruby version 2.7.2 installed, running the command
shopify theme pull --store {store-name}returns an error asking us to install ruby version 2.7.5 or higher.WHAT is this pull request doing?
Bumping the minimum ruby version requirement in the documentation.