Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate payment methods for redeemable #3844

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

marklevi
Copy link
Contributor

@marklevi marklevi commented May 3, 2024

This PR ensures we use the appropriate supported_payment_methods for redeemables and populated redeemable_type if supported_payment_methods is set to gift-card

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@marklevi marklevi self-assigned this May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@marklevi marklevi added the #gsd:37340 Shopify CLI Payment Apps Support label May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.77% (+0.01% 🔼)
6943/9674
🟡 Branches
68.72% (+0.03% 🔼)
3421/4978
🟡 Functions 71.22% 1858/2609
🟡 Lines
73.07% (+0.01% 🔼)
6544/8956

Test suite run success

1633 tests passing in 763 suites.

Report generated by 🧪jest coverage report action from 1550afe

Copy link
Contributor

@bazay bazay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bazay bazay added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 4c8a658 May 3, 2024
@bazay bazay deleted the fix_redeemable_config branch May 3, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:37340 Shopify CLI Payment Apps Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants