Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Include theme-check-docs-updater data folder in final bundled dist #3865

Merged
merged 5 commits into from
May 10, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

There is a bug in theme check where some expected assets can't be found. This is because on the bundled CLI we need to explicitly copy any asset folder.

WHAT is this pull request doing?

  • Copy the data folder from theme-check-data-updater into the final bundled dist folder.

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented May 7, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented May 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.9% 6961/9681
🟡 Branches 68.8% 3426/4980
🟡 Functions 71.29% 1860/2609
🟡 Lines 73.21% 6561/8962

Test suite run success

1637 tests passing in 763 suites.

Report generated by 🧪jest coverage report action from fb97b00

@charlespwd charlespwd force-pushed the fix-theme-check-update-default-files-stab branch from 8ae82c4 to 8558aa3 Compare May 7, 2024 19:05
@charlespwd charlespwd force-pushed the fix-theme-check-update-default-files-stab branch from 8558aa3 to 15b9947 Compare May 10, 2024 12:23
@charlespwd charlespwd force-pushed the fix-theme-check-update-default-files-stab branch from 15b9947 to fb97b00 Compare May 10, 2024 12:24
@isaacroldan isaacroldan merged commit d502326 into stable/3.60 May 10, 2024
32 checks passed
@isaacroldan isaacroldan deleted the fix-theme-check-update-default-files-stab branch May 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants