Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LogStreaming] yarn dev --logs #3889

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[LogStreaming] yarn dev --logs #3889

wants to merge 1 commit into from

Conversation

mssalemi
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@mssalemi mssalemi changed the title [LogStreaming] yarn dev [LogStreaming] yarn dev --logs May 10, 2024
@Shopify Shopify deleted a comment from github-actions bot May 10, 2024
@Shopify Shopify deleted a comment from github-actions bot May 10, 2024
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.5% (-0.4% 🔻)
6973/9752
🟡 Branches
68.51% (-0.24% 🔻)
3427/5002
🟡 Functions
70.98% (-0.33% 🔻)
1861/2622
🟡 Lines
72.77% (-0.46% 🔻)
6573/9033
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / fetch_app_logs.ts
8.33% 0% 0% 8.33%
🔴
... / output.ts
13.64% 0% 0% 13.64%
🔴
... / subscribe_app_logs.ts
33.33% 100% 0% 33.33%
🔴
... / write_app_logs.ts
33.33% 100% 0% 33.33%
🔴
... / app-logs-process.ts
8.33% 0% 0% 8.33%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app_config_webhook.ts
91.3% (-8.7% 🔻)
81.82% (-18.18% 🔻)
100%
90.91% (-9.09% 🔻)
🟢
... / setup-dev-processes.ts
95% (+0.13% 🔼)
66.67% (-1.52% 🔻)
90%
94.29% (+0.17% 🔼)
🟡
... / session.ts
76.47%
62.67% (-0.15% 🔻)
90% 76.72%
🟢
... / spin.ts
97.5%
65.38% (-3.85% 🔻)
100% 97.44%

Test suite run success

1637 tests passing in 763 suites.

Report generated by 🧪jest coverage report action from 8ead06a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants