Fix webhook link logic

[isaacroldan]

Fixes https://github.com/Shopify/develop-app-management/issues/1792

WHY are these changes introduced?

There are two ways of defining webhooks in the toml:

• Condensed: multiple topics in the same subscription definition (sharing the same URI)
• Expanded: each subscription has only 1 topic

When linking to a new app we need to default to the condensed state, but right now we are doing expanded.

WHAT is this pull request doing?

• Remove the simplify function from the specification
• Update the webhook reverse transform to transform from expanded to condensed.
• Add an additional transform to the link command to further condense webhooks

How to test your changes?

See the description in this issue

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

[github-actions]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	71.88% (+0.05% 🔼)	7145/9940
🟡	Branches	69.17% (+0.05% 🔼)	3529/5102
🟡	Functions	71.58% (+0.12% 🔼)	1917/2678
🟡	Lines	73.14% (+0.04% 🔼)	6723/9192

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟡	... / select-app.ts	74.19% (-0.81% 🔻)	80% (-2.35% 🔻)	88.89% (-1.11% 🔻)	76.92% (-0.85% 🔻)
🟢	... / link.ts	96.7% (+0.19% 🔼)	90.91% (-1.03% 🔻)	100%	96.59% (+0.21% 🔼)

Test suite run success

1667 tests passing in 774 suites.

Report generated by 🧪jest coverage report action from 16d806c

[karenxie]

LGTM! thanks for getting this resolved @gracejychang!

[karenxie]

Just curious: what do these numbers mean and why did they change with this PR? I'm guessing it has something to do with the sorting?

[gracejychang]

ohh, I think this might have something to do with condensing the webhooks, instead of sorting? cause the subscriptions look like this after the transform on the schema:

      subscriptions: [
        {
          topics: ['products/update', 'products/update'],
          uri: 'https://example.com',
          filter: 'title:shoes',
        },
      ],

[alexanderMontague]

This isn't a great DX... the number used to tell you what index of [[webhooks.subscriptions]] (ie. the order top to bottom) you should be looking at. Now it will forever be webhooks.subscriptions.0.topics.... I think we should come back to this or at least chat with UX on the best path forward.

[karenxie]

only weirdness I saw when testing is that the the subscriptions showed 0 on the version page, but a refresh showed the subscription I was expecting. not blocking and not related to this PR since it seems to happen on main too but just noting it here

[alexanderMontague]

Not sure I agree with the approach but agreed lets not block and get this shipped! We can clean it up on the server for M2 - thanks for looking into this

[isaacroldan]

Approved 👍