Relative uris declarative subscriptions #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1684 tests passing in 781 suites. Report generated by 🧪jest coverage report action from 9b4b90c |
shauns
reviewed
May 31, 2024
|
|
||
| [[webhooks.subscriptions]] | ||
| topics = [ "products/create", "products/update" ] | ||
| uri = "/webhooks" |
shauns
reviewed
May 31, 2024
packages/app/src/cli/models/extensions/specifications/validation/common.ts
Outdated
Show resolved
Hide resolved
shauns
reviewed
May 31, 2024
| import {WebhooksConfig, NormalizedWebhookSubscription, WebhookSubscription} from '../types/app_config_webhook.js' | ||
| import {deepCompare, deepMergeObjects, getPathValue} from '@shopify/cli-kit/common/object' | ||
|
|
||
| export function transformFromWebhookConfig(content: object) { | ||
| export function transformFromWebhookConfig(content: object, appConfiguration: AppConfigurationWithoutPath) { | ||
| const webhooks = getPathValue(content, 'webhooks') as WebhooksConfig | ||
| if (!webhooks) return content | ||
|
|
||
| const webhookSubscriptions = [] | ||
| // eslint-disable-next-line @typescript-eslint/naming-convention |
There was a problem hiding this comment.
I've added to https://github.com/Shopify/develop-app-management/issues/1797
Maybe we could change https://typescript-eslint.io/rules/naming-convention/#ignore-destructured-names -- if you're destructuring its not really your fault that the names are "wrong".
shauns
approved these changes
May 31, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
depends on #3955
closes https://github.com/Shopify/develop-app-management/issues/1599
Adds relative URIs to your app's URL to declarative webhooks
WHAT is this pull request doing?
exposes the fullAppConfiguration to various deploy and link locations in order to transform webhook subscriptions by checking the application_url