Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a root <Text> element to log files to fix wrapping (3.61 patch) #3960

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

nickwesselman
Copy link
Contributor

3.61 patch for #3959

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.89% 7220/10043
🟡 Branches 69.01% 3545/5137
🟡 Functions 71.51% 1933/2703
🟡 Lines 73.15% 6798/9293

Test suite run success

1682 tests passing in 780 suites.

Report generated by 🧪jest coverage report action from 481d802

@shauns
Copy link
Contributor

shauns commented Jun 3, 2024

:shipit: ?

@nickwesselman
Copy link
Contributor Author

@shauns I can't merge due to CI checks being broken

@isaacroldan
Copy link
Contributor

@nickwesselman It should be fixed now, just rebase with main :)

@nickwesselman
Copy link
Contributor Author

@isaacroldan This is a 3.61 patch though, do we need to apply the CI fix on this patch branch too?

@isaacroldan
Copy link
Contributor

Um, good point. I can remove the checks of node 18.12 for now as an alternative

@isaacroldan
Copy link
Contributor

Actually, those aren't required here. So you can merge 👌

@nickwesselman nickwesselman merged commit 38009b3 into stable/3.61 Jun 4, 2024
1 check passed
@nickwesselman nickwesselman deleted the cooncurrentoutput-wrapping-fix-patch branch June 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants