Print error and continue dev on log streaming subscription failure #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhassan
force-pushed
the
ah.fix-log-streaming-env-not-set
branch
from
1b7fbd4
to
1636ad8
Compare
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
|
Makes sense to me, but we should add a test to cover this |
Coverage report
Test suite run success1691 tests passing in 789 suites. Report generated by 🧪jest coverage report action from 6dff09a |
lopert
approved these changes
Jun 6, 2024
andrewhassan
force-pushed
the
ah.fix-log-streaming-env-not-set
branch
from
1636ad8
to
513cfe3
Compare
DuncanUszkay1
approved these changes
Jun 6, 2024
andrewhassan
force-pushed
the
ah.fix-log-streaming-env-not-set
branch
from
513cfe3
to
6dff09a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/shopify-functions/issues/220
In cases where we encounter an error creating an app log streaming subscription (e.g. the user doesn't have the necessary permissions), the CLI prints the error and continues. This leads to a downstream error halting the
devprocess.WHAT is this pull request doing?
This PR updates the logic such that when there is an error subscribing, the error is printed out and the
devprocess continues.How to test your changes?
SHOPIFY_CLI_ENABLE_APP_LOG_POLLING=1and the organization beta flag offapp devand see that an error message is printed, butdevcontinuesScreenshots
Checklist
I've made sure that any changes toThis link is dead 😢devordeployhave been reflected in the internal flowchart.