Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative path declarative webhooks #4056

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

alexanderMontague
Copy link
Contributor

This reverts commit 35b85e2.

We are going with relative paths for the time being 🔁 😄
More details in https://github.com/Shopify/develop-app-inner-loop/issues/1599

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.04% (+0.06% 🔼)
7374/10236
🟡 Branches
68.95% (+0.13% 🔼)
3621/5252
🟡 Functions
71.55% (+0.06% 🔼)
1954/2731
🟡 Lines
73.31% (+0.07% 🔼)
6954/9486
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app_config_privacy_compliance_webhooks.ts
100%
93.94% (-2.36% 🔻)
100% 100%
🟢
... / common.ts
87.5% (-12.5% 🔻)
88.89% (-11.11% 🔻)
100% 100%

Test suite run success

1700 tests passing in 793 suites.

Report generated by 🧪jest coverage report action from 634bd56

@alexanderMontague alexanderMontague changed the title revert "revert relative declarative webhook URIs" relative path declarative webhooks Jun 14, 2024
@alexanderMontague
Copy link
Contributor Author

Confirmed tophat working 🎩 ✅

@alexanderMontague alexanderMontague merged commit 451e481 into main Jun 17, 2024
36 checks passed
@alexanderMontague alexanderMontague deleted the add_back_in_relative_paths branch June 17, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants