-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade vitest #4073
Upgrade vitest #4073
Conversation
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Test suite run success1704 tests passing in 794 suites. Report generated by 🧪jest coverage report action from 4de33b7 |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/fs.d.ts@@ -1,6 +1,5 @@
/// <reference types="node" resolution-mode="require"/>
/// <reference types="node" resolution-mode="require"/>
-/// <reference types="node" resolution-mode="require"/>
import { RandomNameFamily } from '../common/string.js';
import { OverloadParameters } from '../../private/common/ts/overloaded-parameters.js';
import { findUp as internalFindUp } from 'find-up';
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@@ -95,7 +95,7 @@ | |||
"version": "0.0.0", | |||
"resolutions": { | |||
"@types/react": "17.0.2", | |||
"vite": "4.4.9", | |||
"vite": "5.3.1", | |||
"@oclif/core": "3.26.5", | |||
"whatwg-url": "14.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check if we can remove this? A punycode warning was shown with Node 22, and I think vite was one of the culprits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it can be removed. The extensions console uses vite to build for instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant whatwg-url
. Maybe with the Vite upgrade we don't need to pin this version anymore.
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-app-inner-loop/issues/1826
WHAT is this pull request doing?
Upgrades vitest & vite across the board; fixes some test incompatibilities
How to test your changes?
p test
andp vitest
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.