Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vitest #4073

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Upgrade vitest #4073

merged 7 commits into from
Jun 18, 2024

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Jun 18, 2024

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-app-inner-loop/issues/1826

WHAT is this pull request doing?

Upgrades vitest & vite across the board; fixes some test incompatibilities

How to test your changes?

  • Run p test and p vitest
  • Restart VS code and see that the vitest explorer is now working, and that tests can also be run directly from the editor

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Jun 18, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.46% (+0.35% 🔼)
7392/10201
🟡 Branches 69.11% 3635/5260
🟡 Functions 71.58% 1962/2741
🟡 Lines
72.8% (-0.58% 🔻)
6978/9585

Test suite run success

1704 tests passing in 794 suites.

Report generated by 🧪jest coverage report action from 4de33b7

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/fs.d.ts
@@ -1,6 +1,5 @@
 /// <reference types="node" resolution-mode="require"/>
 /// <reference types="node" resolution-mode="require"/>
-/// <reference types="node" resolution-mode="require"/>
 import { RandomNameFamily } from '../common/string.js';
 import { OverloadParameters } from '../../private/common/ts/overloaded-parameters.js';
 import { findUp as internalFindUp } from 'find-up';

Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@@ -95,7 +95,7 @@
"version": "0.0.0",
"resolutions": {
"@types/react": "17.0.2",
"vite": "4.4.9",
"vite": "5.3.1",
"@oclif/core": "3.26.5",
"whatwg-url": "14.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if we can remove this? A punycode warning was shown with Node 22, and I think vite was one of the culprits.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it can be removed. The extensions console uses vite to build for instance

Copy link
Contributor

@gonzaloriestra gonzaloriestra Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant whatwg-url. Maybe with the Vite upgrade we don't need to pin this version anymore.

@shauns shauns added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit af74972 Jun 18, 2024
36 checks passed
@shauns shauns deleted the upgrade-vitest-2 branch June 18, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants