Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If dev github... fails, don't fail the schema fetch command #4106

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Jun 20, 2024

WHY are these changes introduced?

Internally, we use dev github... to pull in some schema files. If this fails, don't fail the underlying command (usually dev up) -- the developer can continue to work regardless.

WHAT is this pull request doing?

exit code 0 if the error is specifically from using dev

How to test your changes?

Run dev up

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.58% (+0.01% 🔼)
7451/10266
🟡 Branches
69.14% (+0.02% 🔼)
3656/5288
🟡 Functions 71.57% 1969/2751
🟡 Lines
72.92% (+0.01% 🔼)
7037/9650

Test suite run success

1713 tests passing in 794 suites.

Report generated by 🧪jest coverage report action from 3027198

Copy link

@mathiusj mathiusj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works in my spin:
image

@mathiusj
Copy link

and when running pnpm graphql-codegen:get-graphql-schemas:

image

@shauns shauns added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit c89edaf Jun 20, 2024
36 checks passed
@shauns shauns deleted the fail-gracefully-if-unable-to-get-schemas branch June 20, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants