Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changeset for log streaming #4109

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Changeset for log streaming #4109

merged 2 commits into from
Jun 20, 2024

Conversation

nickwesselman
Copy link
Contributor

WHY are these changes introduced?

Changelog in aggregate for this new feature.

@nickwesselman nickwesselman marked this pull request as ready for review June 20, 2024 20:52
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 72.62% 7474/10292
🟡 Branches 69.22% 3672/5305
🟡 Functions 71.58% 1975/2759
🟡 Lines 72.96% 7060/9676

Test suite run success

1719 tests passing in 794 suites.

Report generated by 🧪jest coverage report action from a5b2182

andrewhassan
andrewhassan approved these changes Jun 20, 2024
View reviewed changes
.changeset/smart-hounds-reply.md Outdated Show resolved Hide resolved
@nickwesselman nickwesselman added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit c515360 Jun 20, 2024
34 checks passed
@nickwesselman nickwesselman deleted the functions-log-streaming-changeset branch June 20, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhassan andrewhassan andrewhassan approved these changes

@DuncanUszkay1 DuncanUszkay1 DuncanUszkay1 approved these changes

@shauns shauns Awaiting requested review from shauns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickwesselman @andrewhassan @DuncanUszkay1