Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prompt from CLI2 #4175

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Remove prompt from CLI2 #4175

merged 5 commits into from
Jul 10, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

There is a prompt in CLI2 that appears sometimes that breaks the output of CLI3.
We shouldn't show any prompt from CLI2

WHAT is this pull request doing?

Completely remove the prompt in CLI2
Also disable reporting in CLI2

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.46% (+0.01% 🔼)
7547/10416
🟡 Branches
69.2% (+0.02% 🔼)
3719/5374
🟡 Functions 71.44% 1996/2794
🟡 Lines
72.78% (+0.01% 🔼)
7127/9792

Test suite run success

1736 tests passing in 800 suites.

Report generated by 🧪jest coverage report action from d0ec491

@isaacroldan isaacroldan added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit ae4fce7 Jul 10, 2024
36 checks passed
@isaacroldan isaacroldan deleted the remove-cli-2-prompt branch July 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants