Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TS 4.84, OCLIF 1.16.4 #555

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Upgrade TS 4.84, OCLIF 1.16.4 #555

merged 7 commits into from
Oct 20, 2022

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Oct 3, 2022

WHY are these changes introduced?

Fixes https://github.com/Shopify/shopify-cli-planning/issues/394

WHAT is this pull request doing?

  • Upgrades Typescript to 4.8.4 (current latest)
  • Upgrades OCLIF to 1.16.4 (also the current latest)
  • Fixes some very small incompatibilities

How to test your changes?

We'll want to do a full run through really. Main thing to watch out for are changes in how OCLIF behaves, e.g. when it flushes output.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@shauns shauns self-assigned this Oct 3, 2022
@shauns shauns marked this pull request as ready for review October 20, 2022 14:44
@shauns shauns requested a review from a team October 20, 2022 14:44
@shauns shauns requested review from a team as code owners October 20, 2022 14:44
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.

@shauns shauns merged commit 45e817b into main Oct 20, 2022
@shauns shauns deleted the upgrade-ts-oclif branch October 20, 2022 15:07
@amcaplan amcaplan mentioned this pull request Oct 24, 2022
6 tasks
@shopify-shipit shopify-shipit bot temporarily deployed to production October 25, 2022 11:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants