Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react import for public extension build #590

Closed

Conversation

faouzioudouh
Copy link
Contributor

This is just an improvement PR Related to Shopify/shopify-cli-extensions#127, #577, #588 and #587

Conditionally remove react import from checkout-ui react template when using node build (isShopify)

WHAT is this pull request doing?

How to test your changes?

Public build:

  • Clone this branch
  • Generate new app
  • Geneate new extension using yarn shopify app generate extension --path path-to-app
  • you should see react import at the top of src/index.(t/j)sx file

Shopify build:

  • Clone this branch
  • Generate new app
  • Geneate new extension using SHOPIFY_RUN_AS_USER=1 yarn shopify app generate extension --path path-to-app
  • react import should no exist at the top of src/index.(t/j)sx file

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@isaacroldan
Copy link
Contributor

isaacroldan commented Oct 6, 2022

This is a temporary fix while both Node and Go servers live together right? Is this fix urgent?
In a week or so we'll make the Node server the default, so this code will have a short life... can we wait until that moment?

@faouzioudouh
Copy link
Contributor Author

@isaacroldan yes this is a temporary fix and also not urgent, if Node server will be the default in a week let's not merge this PR then, as it won't be needed

Thanks for the feedback

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants