add react import for public extension build #590
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an improvement PR Related to Shopify/shopify-cli-extensions#127, #577, #588 and #587
Conditionally remove
react
import from checkout-ui react template when using node build (isShopify
)WHAT is this pull request doing?
How to test your changes?
Public build:
yarn shopify app generate extension --path path-to-app
react import
at the top ofsrc/index.(t/j)sx
fileShopify build:
SHOPIFY_RUN_AS_USER=1 yarn shopify app generate extension --path path-to-app
react import
should no exist at the top ofsrc/index.(t/j)sx
fileMeasuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.