Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Polish Review: Contact page #102

Closed
3 tasks
Oliviammarcello opened this issue Jul 5, 2021 · 4 comments · Fixed by #122
Closed
3 tasks

UI Polish Review: Contact page #102

Oliviammarcello opened this issue Jul 5, 2021 · 4 comments · Fixed by #122
Assignees
Labels
Category: Enhancement New feature or request Severity: 1 Urgent Severity

Comments

@Oliviammarcello
Copy link
Contributor

Oliviammarcello commented Jul 5, 2021

UI polish review:

  • For the Contact section (not the template) can we add a heading input to the settings? Figma The styling of the heading should match all other section headings
  • On both the contact form template and section, the form field labels are misaligned in the container on both desktop and mobile. Screenshot.
  • For the success message, can the green check align to the text on the first line instead of the center? Screenshot
@Oliviammarcello Oliviammarcello created this issue from a note in Dawn: Iterations Roadmap (UI Polish ✨) Jul 5, 2021
@Oliviammarcello Oliviammarcello changed the title UI Polish Review: Contact page [WIP] UI Polish Review: Contact page Jul 5, 2021
@ludoboludo ludoboludo self-assigned this Jul 5, 2021
@melissaperreault
Copy link
Contributor

On both the contact form template and section, the form field labels are misaligned in the container on both desktop and mobile.

@ludoboludo I would suggest to look at the global style as well to ensure all input or select components have good vertical alignment 🙏

@melissaperreault melissaperreault added Category: Enhancement New feature or request Severity: 1 Urgent Severity labels Jul 5, 2021
@ludoboludo
Copy link
Contributor

The label font size is set to 1.6rem on both mobile and desktop. Is that ok to keep it that way ? I ask specifically for mobile:

@melissaperreault
Copy link
Contributor

melissaperreault commented Jul 5, 2021

Is that ok to keep it that way ? I ask specifically for mobile

I think so, but open to chat about the waterfall effect. I believe this was changed due to the zoom default iOS have on fonts smaller than 16px.
The page width became bigger for some reason and didn't revert back when form field input text size is smaller.

Image.from.iOS.1.MP4

@ludoboludo
Copy link
Contributor

Ah right I forgot about this thing, perfect. It's easier for me to keep it this way anyway :)

@ludoboludo ludoboludo mentioned this issue Jul 6, 2021
5 tasks
@sofiamatulis sofiamatulis moved this from UI Polish ✨ to In progress in Dawn: Iterations Roadmap Jul 6, 2021
@Oliviammarcello Oliviammarcello changed the title [WIP] UI Polish Review: Contact page UI Polish Review: Contact page Jul 7, 2021
Dawn: Iterations Roadmap automation moved this from In progress to Done Jul 7, 2021
antiBaconMachine pushed a commit that referenced this issue Mar 16, 2023
Implement the recipient form for gift card product
antiBaconMachine pushed a commit that referenced this issue Mar 17, 2023
Implement the recipient form for gift card product
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Enhancement New feature or request Severity: 1 Urgent Severity
Development

Successfully merging a pull request may close this issue.

3 participants