Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Contact] Empty heading H2 #1459

Closed
svinkle opened this issue Mar 7, 2022 · 0 comments · Fixed by #1515
Closed

[Contact] Empty heading H2 #1459

svinkle opened this issue Mar 7, 2022 · 0 comments · Fixed by #1515
Assignees
@kmeleta
Labels
Category: Accessibility Bugs found while using assistive technology Critical Path: 1 Affects all merchants/buyers Effort: Low Severity: 3 Normal/Low Severity
Projects
Dawn: Iterations Roadmap

Comments

@svinkle
Copy link
Member

svinkle commented Mar 7, 2022

Issue summary

On contact page templates, an empty heading h2 exists directly above the form.

Discovered while running WAVE Evaluation Tool.

Screenshots Screenshot of a contact form. Space above the form fields is highlighted representing the empty heading position.

Current code

HTML

<h2 class="title"></h2>

Steps to reproduce

  1. Go to any Dawn demo store "Contact Us" with any supported browser
  2. Run the WAVE Evaluation Tool and review the Errors tab

Behavior

Expected

  • Empty headings to not be present.

Actual

  • And empty h2 heading is in the DOM.

Recommendation

On "Contact Us" templates only, remove the empty h2 element from the DOM. Keep the heading for "Contact Us" sections.

Specifications
@svinkle svinkle added Severity: 3 Normal/Low Severity Category: Accessibility Bugs found while using assistive technology Effort: Low Critical Path: 1 Affects all merchants/buyers labels Mar 7, 2022
@svinkle svinkle added this to To be triaged in Dawn: Iterations Roadmap via automation Mar 7, 2022
@nicklepine nicklepine moved this from To be triaged to Accessibility in Dawn: Iterations Roadmap Mar 17, 2022
@kmeleta kmeleta self-assigned this Mar 21, 2022
@kmeleta kmeleta mentioned this issue Mar 21, 2022
Merged
6 tasks
Dawn: Iterations Roadmap automation moved this from Accessibility to Done Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmeleta kmeleta

Labels
Category: Accessibility Bugs found while using assistive technology Critical Path: 1 Affects all merchants/buyers Effort: Low Severity: 3 Normal/Low Severity
Projects
Dawn: Iterations Roadmap
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent empty heading in contact form Shopify/dawn
2 participants
@svinkle @kmeleta