Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Grid: Filtering] Vertical filter #1501

Closed
duygukalaycioglu opened this issue Mar 16, 2022 · 6 comments · Fixed by #1443
Closed

[Product Grid: Filtering] Vertical filter #1501

duygukalaycioglu opened this issue Mar 16, 2022 · 6 comments · Fixed by #1443
Assignees

Comments

@duygukalaycioglu
Copy link

No description provided.

@duygukalaycioglu
Copy link
Author

📖 Brief
Introduce vertical filters in addition to horizontal filter layout as an additional option.

✏️ Tasks:
1. Settings

  • Remove collapse on desktop from product grid/filtering and sorting settings
  • Add "desktop filter layout" dropdown with 3 filter layout options and sub-copy.

settings-updates

2. Design
a. Horizontal filter layout: No change.
horizontal filters

  • b. Drawer filter layout: Drawer is an existing interaction, the only change is adding this as a filter layout option in the new dropdown under settings. Sort won't be grouped with filters on desktop for any filter layout option.
    📌 The filter experience always defaults to drawer on mobile, and this is the only instance sort and filter will be grouped together. (for more info: visit Figma file, approved by: ✅ @danielvan)

drawer filter layout

  • c. Vertical filter layout: This is a new filter layout.

  • Vertical filter/ Default state: Open the first filter group by default when the desktop filter layout is set to vertical by the merchant.

default

  • Vertical filter/ Filters selected from 1 filter group:
    When the buyer selects filters;

  • display pills on top and “clear all”

  • update the filter group name with the number of filters the buyer selected

applied one

Filters selected from multiple filter groups:
The pills keep stacking at the top.
applied multiple

  • Vertical filter/ Clear all:
    When a buyer clicks to “clear all”;
  • clear all pills
  • remove “clear all”
  • remove the numbers from the filter group names
  • uncheck all selected filters

📌 Arrows: Buyer can manually open or close the filters by clicking the filter group name or arrow. When buyer opens a filter group, the arrows turns up (following the same interaction on mega menu)
clear all

  • Vertical filter/ Show more x less:
    Display “show more” when the total number of filters is >10. Hide if the total number of filters is <10. Clicking “show more” should display the rest of the filters and turn the text into “show less”. Text style for both links: underlined.

show more - less

📌 @sofiamatulis as we discussed during the design hand-off meeting, let's keep an eye on when this update is being merged: Boolean filters. I can update the designs when needed. (approved by: ✅ @nicklepine) cc: @tyleralsbury

@bredowmax
Copy link
Contributor

Starting to look really good! One thing I noticed when testing: With a number of boolean metafields:

  1. The chips would need to identify the metafield
  2. The dropdown mechanism needs a lot of space & clicks.

Screen Shot 2022-03-17 at 10 03 55 AM

I would prefer a chip or a checkbox that I can click to activate/deactivate rather than the current implementation. See Amazon:
Screen Shot 2022-03-17 at 10 08 25 AM

@bredowmax
Copy link
Contributor

Update: after latest code changes, the chips now do provide more information - great. One issue that remains, however, is that these drop-downs are incredibly slow to use. In case of booleans, I'd much prefer a simple checkbox, not hidden behind a dropdown (see my screenshot above from Amazon)

FYI @duygukalaycioglu

Screen Shot 2022-03-17 at 12 17 44 PM

@duygukalaycioglu
Copy link
Author

Thank you for the feedback @bredowmax! Boolean filters are not part of vertical filter project's scope. I recommend you to create a separate ticket for boolean filter related feedback and cc: @carolineschnapp.

@duygukalaycioglu
Copy link
Author

duygukalaycioglu commented Mar 17, 2022

I'd much prefer a simple checkbox, not hidden behind a dropdown (see my screenshot above from Amazon)

Thanks for sharing your thoughts! @breadowmax Using drawers for vertical filters was a design decision we made after our benchmarking and explorations. The drawers enable the merchants to collect their filters under specific filter groups and for buyers it is easier to grasp the amount of filter groupings quickly rather than scrolling through a very long list of exposed filters.

@danielvan
Copy link
Contributor

Is the plan for us to keep all boolean filters in drawers too? It seems a strange experience to have a drawer for a single checkbox. Or was this done because right now we can't really identify when something under a category is a boolean and then surface it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants