Footer newsletter sign up displays errors from contact form

[pm-zr]

Describe the current behavior

If the contact form is unsuccessfully submitted the footer newsletter signup displays the error from email field for the contact form

Describe the expected behavior

errors for each form would be isolated to the form submitted.

Version information (Dawn, browsers and operating systems)

• Dawn Version: 6.0.2

Possible solution

Check for form.id when displaying errors to ensure the error is from the form in question. There may be other ways to handle this.

Additional context/screenshots

Visit this link to reproduce on the demo store: Demo store submitted form

[pm-zr]

Can't upload a screenshot for some reason right now, link above will reproduce. Or just submit a blank form, complete recaptcha if needed.

The default error state of a form field also seems to need some more thought. It seems to be incompletely styled on the demo store.

[shawnr42]

There is no form.id that can be used as a way to make sure that the error applies to a specific form.

My current workaround is to check for a field besides the email field that I know is the in the contact form. For the contact form I use form.Name for the name field on the form.

That means that on the Newsletter section, instead of just looking for an error like this

{%- if form.errors %}

and instead, check for the errors, and that there is no "Name" field content.

{%- if form.errors and form.Name == blank -%}

It's not perfect, but it can help.