Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Password page] "Shopify" logo link opens in a new window without warning #721

Closed
svinkle opened this issue Sep 30, 2021 · 0 comments · Fixed by #1735
Closed

[Password page] "Shopify" logo link opens in a new window without warning #721

svinkle opened this issue Sep 30, 2021 · 0 comments · Fixed by #1735
Labels
Category: Accessibility Bugs found while using assistive technology Critical Path: 3 Affects few merchants/buyers Effort: Low Severity: 3 Normal/Low Severity

Comments

@svinkle
Copy link
Member

svinkle commented Sep 30, 2021

Issue summary

The "Shopify" logo link opens a new window without warning the user. This could confuse screen reader users or cognitive impaired users who, when discover and interact with the link, believe they are following a link in the same browser window. This also causes extra work for sighted, keyboard-only users to switch back to the previous tab or window.

Screenshots Dawn theme, password page. Shopify logo link is highlighted.

Current code

HTML

<a
  class="shopify-link"
  href="//www.shopify.com"
  rel="nofollow"
  target="_blank"
  
>
  <!-- SVG… -->
</a>

Steps to reproduce

  1. Go to a Dawn theme store with a password enabled with any supported browser
  2. Navigate to the /password page
  3. With an active screen reader, navigate to the Shopify image link in the footer

Behavior

Expected

  • Links which open a new window will be accompanied by a visual and aural warning.

Actual

  • Link opens a new window without warning.

Recommendation

  1. Add a new hidden element to the DOM which includes the warning text.
  2. Add the aria-describedby attribute to the link, setting its value to the id of the warning text container, providing an audible warning.

Recommended code

HTML

<div hidden id="warning-text">Opens in a new window.</div>

<!-- … -->

<a
  class="shopify-link"
  href="//www.shopify.com"
  rel="nofollow"
  target="_blank"
  
  aria-describedby="warning-text"
>
  <!-- SVG… -->
</a>

Specifications

@svinkle svinkle added Severity: 3 Normal/Low Severity Category: Accessibility Bugs found while using assistive technology Effort: Low labels Sep 30, 2021
@svinkle svinkle added this to To be triage in Dawn: Iterations Roadmap Oct 1, 2021
@svinkle svinkle added the Critical Path: 3 Affects few merchants/buyers label Nov 26, 2021
@nicklepine nicklepine moved this from To be triage to Accessibility in Dawn: Iterations Roadmap Feb 4, 2022
Dawn: Iterations Roadmap automation moved this from Accessibility to Done Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Accessibility Bugs found while using assistive technology Critical Path: 3 Affects few merchants/buyers Effort: Low Severity: 3 Normal/Low Severity
Development

Successfully merging a pull request may close this issue.

1 participant