Fix disabled links refresh page

[hoektoe]

Why are these changes introduced?

Fixes #8.

Affected components are:

• image-with-text
• image-banner

What approach did you take?
Components with anchor links that could be empty, check for blank URL and remove the Href from the anchor tag. This approach still shows the end-user disabled cursor as per CSS styling for aria-disabled

Hovering over anchors without Href shows end-user disabled cursor and does nothing when clicked

Other considerations

• Pointer-events: none, this approach nullified the cursor CSS and unwanted consequences
• javascript:void(0) , this approach could also work, but since removing Href is HTML standard it's probably better.

Demo links

• Store pass: fix8

Checklist

• Followed theme code principles
• Linted with Theme Check
• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility

[bertiful]

Thanks for the contribution @hoektoe. Small suggestion to remove some extra whitespace otherwise we're good 👍🏻

[tyleralsbury]

Thanks for the contribution! Great idea, and it works well. ✅

As Chris mentioned, a little whitespace cleanup, but otherwise looks great.

[hoektoe]

Thanks, @chrisberthe , applied the suggestions. Didn't know could leave a code suggestion like that and have it applied/accepted like that.

Hope all is well?

[bertiful]

Yeah, nifty little GitHub feature. Something else that's pretty cool is that you can look at the "Files changed" tab and batch the suggestions together into a single commit instead of committing each suggestion separately.

Code looks good btw! We'll just wait on @tyleralsbury to review the latest. Thanks for your contribution :)

[tyleralsbury]

Looks good - tested and code ✅