Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer.liquid #137

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Update footer.liquid #137

merged 1 commit into from
Jul 13, 2021

Conversation

ninasaeheng
Copy link
Contributor

Missing dash in col classname.
grid--4col-desktop > grid--4-col-desktop

Missing dash in col classname.
@ghost ghost added the cla-needed label Jul 7, 2021
Copy link
Contributor

@bertiful bertiful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ninasaeheng

Copy link
Contributor

@tyleralsbury tyleralsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice catch!

@bertiful
Copy link
Contributor

bertiful commented Jul 7, 2021

@ninasaeheng you'll just need to ensure you sign the CLA before merging.

@tauthomas01 tauthomas01 mentioned this pull request Jul 12, 2021
@tauthomas01
Copy link
Contributor

Hi @ninasaeheng, as @chrisberthe mentioned, would it be possible to sign in the CLA so we can merge it?

@ninasaeheng
Copy link
Contributor Author

@tauthomas01 @chrisberthe sorry, signed!

@ninasaeheng ninasaeheng reopened this Jul 12, 2021
@tauthomas01
Copy link
Contributor

@ninasaeheng I still see the CLA not being signed.

image

@ghost ghost removed the cla-needed label Jul 13, 2021
@tauthomas01
Copy link
Contributor

I re-run the CLA test, and it works well now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants